changes to make proxy gateway only start while VPN is ON, and quit wh… #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! As you mention, this may not be ideal for everyone, so we will likely need to add some preferences to control this behavior but this is a great suggestion. We've put this on our board to integrate in a future release. You will be credited when we do so. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might not be ideal for everyone, but i didn't want the gateway proxy to be proxying unless the VPN was also on, otherwise apps that use the https/socks proxy to be private could unintentionally leak
this changes it so the proxy gateway runs ONLY when the VPN is also on, and turns it off afterward, causing apps using the proxy to fail when connection isn't secured, ideal for me, but others might want some kind of option to work this way or all the time
only tested with socks but should work for both, works for me, very happy this is open source